Skip to content

Add new parameter as rememberGooglePayLauncher#10950

Open
winter-love-dev wants to merge 1 commit into
stripe:masterfrom
winter-love-dev:add-new-param-as-google-pay-launcher
Open

Add new parameter as rememberGooglePayLauncher#10950
winter-love-dev wants to merge 1 commit into
stripe:masterfrom
winter-love-dev:add-new-param-as-google-pay-launcher

Conversation

@winter-love-dev

@winter-love-dev winter-love-dev commented Jun 13, 2025

Copy link
Copy Markdown

Summary

Added optional publishableKey parameter to rememberGooglePayLauncher() to allow direct key specification without modifying singleton configuration.

Motivation

Eliminates need to reinitialize PaymentConfiguration singleton when switching between different country-specific publishable keys, reducing code complexity and preventing potential race conditions.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@winter-love-dev winter-love-dev requested review from a team as code owners June 13, 2025 13:49
@cla-assistant

cla-assistant Bot commented Jun 13, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented Jun 13, 2025

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tianzhao-stripe

Copy link
Copy Markdown
Contributor

Hi @winter-love-dev

Thanks for your contribution, we've added this to our roadmap and we're working on getting it approved and added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants