Support arbitrary objects as the sole element in msgAndArgs#699
Merged
georgelesica-wf merged 2 commits intostretchr:masterfrom Dec 12, 2018
Merged
Conversation
Contributor
Author
|
@georgelesica-wf Can you review this? (Test failure is only on |
georgelesica-wf
approved these changes
Dec 11, 2018
georgelesica-wf
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Sorry it took a couple days for me to get to it. I'm going to have one additional person review it just in case, but I don't anticipate any issues.
Contributor
Author
|
Thanks @georgelesica-wf! |
bencampbell-wf
approved these changes
Dec 12, 2018
Contributor
Author
|
Thanks for merging! Do you know when you'll cut a release next? |
|
I need to figure out the process the project follows for that, but I'll try to do it next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if
msgAndArgscontains exactly one element, it's expected to be astring-- and if it's not, the framework panics, which makes it hard to debug the actual test failure. So, if the object passed is not a string, then print it using the%+vmodifier.This will make life slightly more convenient for clients. It doesn't break existing programs in any way.