Format matched arguments with %v to avoid panic#596
Merged
ernesto-jimenez merged 2 commits intostretchr:masterfrom Jun 9, 2018
Merged
Format matched arguments with %v to avoid panic#596ernesto-jimenez merged 2 commits intostretchr:masterfrom
ernesto-jimenez merged 2 commits intostretchr:masterfrom
Conversation
ernesto-jimenez
approved these changes
Jun 9, 2018
Member
|
@gz-c thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some values will panic when fmt.Sprintf'd with
%s, e.g. https://godoc.org/github.com/boltdb/bolt#Tx.When mocking a method that has such a value in its arguments, the program will panic due to Argument.Diff attempting to print the interface{} type with
%s.Normally the compiler will prevent using such a value in a formatter but the code bypasses this by operating on
interface{}.This PR changes the formatter to use
(%T=%v).%Tis used to mimic the previous behaviour which generated outputs like%!s(int=123).