Fix vim-go integration and other editors#554
Merged
ernesto-jimenez merged 1 commit intomasterfrom Feb 2, 2018
Merged
Conversation
42f063a to
6caeaba
Compare
This was referenced Feb 1, 2018
Use Go 1.9 t.Helper() to remove testify from the output of the tests and stop using `\r` to try to overwrite the output. This means in Go 1.7 and Go 1.8 testify will appear as failing the test.
6caeaba to
02bda42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Go 1.9 t.Helper() to remove testify from the output of the tests and
stop using
\rto try to overwrite the output.This means in Go 1.7 and Go 1.8 testify will appear as failing the test.