chore: vendor go-spew from https://github.com/davecgh/go-spew#1827
Merged
brackendawson merged 5 commits intostretchr:masterfrom Nov 28, 2025
Merged
chore: vendor go-spew from https://github.com/davecgh/go-spew#1827brackendawson merged 5 commits intostretchr:masterfrom
brackendawson merged 5 commits intostretchr:masterfrom
Conversation
e46975b to
cf0e543
Compare
cf0e543 to
3987752
Compare
This was referenced Nov 18, 2025
brackendawson
approved these changes
Nov 27, 2025
Collaborator
brackendawson
left a comment
There was a problem hiding this comment.
The license is handled properly and is compatible with what we're doing. I have checked and the import is a faithful verbatim copy. In this case we didn't keep the history as we did with difflib, but we decided that's not mandatory in the vendoring of ernesto-jimenez/gogen. The modifications to fit it into the internal directory are also fine.
Big!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vendor go-spew
Changes
Import unmaintained library
Motivation
go-spew is unfortunately unmaintained, we cannot expect a fix any time soon.
vendoring go-spew, the same way we vendored go-difflib would help us to remove bugs, but also keep the current pretty print lib without moving to something else.
Note: we have already vendored the go-difflib we are using to compare the go-spew results.
Related issues
Closes #1826