Conversation
Collaborator
Author
|
@SuperQ Could you review this? |
Contributor
|
LGTM, but maybe the test is flakey? |
SuperQ
approved these changes
Jul 6, 2023
This was referenced Jul 6, 2023
Merged
Contributor
|
So strange that the tests pass now. |
Collaborator
Author
|
@SuperQ Note that I have merged a few PRs yesterday and I have rebased my branch. |
16f80b8 to
ac011f3
Compare
ac011f3 to
d618ad0
Compare
This was referenced Oct 10, 2023
Collaborator
Author
|
I had to merge #1451 instead, because I lack the permissions to merge my own MRs. 😭 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade CI to use setup-go v4
Motivation
Use latest features such as module cache.