fix: object formatting in Len message#1405
Closed
rprtr258 wants to merge 1 commit intostretchr:masterfrom
rprtr258:master
Closed
fix: object formatting in Len message#1405rprtr258 wants to merge 1 commit intostretchr:masterfrom rprtr258:master
rprtr258 wants to merge 1 commit intostretchr:masterfrom
rprtr258:master
Conversation
alexandear
reviewed
Jul 6, 2023
alexandear
suggested changes
Nov 21, 2023
Contributor
alexandear
left a comment
There was a problem hiding this comment.
Perhaps we need to extend tests for the fixes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Change formatting in
Lenmethod from%stospew.DumpMotivation
Old code prints:
which contains invalid formatting
%!s(int=1)Related issues