Refactor assertions to use generics#1308
Draft
TheAndrew2115 wants to merge 4 commits intostretchr:masterfrom
Draft
Refactor assertions to use generics#1308TheAndrew2115 wants to merge 4 commits intostretchr:masterfrom
TheAndrew2115 wants to merge 4 commits intostretchr:masterfrom
Conversation
5e6fe2d to
661fad8
Compare
dolmen
reviewed
Jul 11, 2023
Collaborator
dolmen
left a comment
There was a problem hiding this comment.
This implementation puts much more compile-time constraints on types. I expect this will break existing code.
| // assert.InDelta(t, math.Pi, 22/7.0, 0.01) | ||
| func InDelta(t TestingT, expected, actual interface{}, delta float64, msgAndArgs ...interface{}) bool { | ||
| // assert.InDelta(t, math.Pi, 22/7.0, 0.01) | ||
| func InDelta[T ConvertibleToFloat64](t TestingT, expected, actual T, delta float64, msgAndArgs ...interface{}) bool { |
Collaborator
There was a problem hiding this comment.
InDelta should only take ~float32 | ~float64. ConvertibleToFloat64 is too wide.
assert/assertions.go
Outdated
|
|
||
| // NotZero asserts that i is not the zero value for its type. | ||
| func NotZero(t TestingT, i interface{}, msgAndArgs ...interface{}) bool { | ||
| func NotZero[T any](t TestingT, i T, msgAndArgs ...interface{}) bool { |
Collaborator
There was a problem hiding this comment.
Inconsistency with Zero where i is ìnterface{}`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Motivation
Related issues