fix: assert.MapSubset (or just support maps in assert.Subset)#1178
Merged
boyan-soubachov merged 2 commits intostretchr:masterfrom Jun 28, 2022
OladapoAjala:1173-support-maps-in-assert-subset
Merged
fix: assert.MapSubset (or just support maps in assert.Subset)#1178boyan-soubachov merged 2 commits intostretchr:masterfrom OladapoAjala:1173-support-maps-in-assert-subset
boyan-soubachov merged 2 commits intostretchr:masterfrom
OladapoAjala:1173-support-maps-in-assert-subset
Conversation
boyan-soubachov
approved these changes
Jun 28, 2022
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
Looks good, thank you for your contribution :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extended Subset & NotSubset to handle maps
Changes
Added some logic to check if each subsets key-value pair are present in the list.
Motivation
To handle maps in Subset & NotSubset
Related issues
#1173