Allow mock expectations to be ordered#1106
Merged
boyan-soubachov merged 3 commits intostretchr:masterfrom Jun 28, 2022
Merged
Conversation
boyan-soubachov
previously approved these changes
Jul 28, 2021
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
LGTM, thank you for your contribution :)
|
When will this be merged? |
|
Are we missing something to merge this? |
Collaborator
|
There are conflicts to resolve on |
Collaborator
Author
|
There you go. 🙂 |
boyan-soubachov
approved these changes
Jun 28, 2022
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
Looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow mock expectations to be ordered
Changes
Callto be used inMock.ExpectedCallsa[]*Callwhich must all be satisfied first.Call.NotBefore()to allow the above to be populated.Mock.checkExpectation().Motivation
People want to check that some calls were made in a necessary order.
Related issues
Closes #741