Make sure time.Time comparison produces a helpful diff. closes #989#1072
Merged
boyan-soubachov merged 1 commit intostretchr:masterfrom Apr 27, 2021
Merged
Make sure time.Time comparison produces a helpful diff. closes #989#1072boyan-soubachov merged 1 commit intostretchr:masterfrom
boyan-soubachov merged 1 commit intostretchr:masterfrom
Conversation
Contributor
Author
Contributor
Author
Contributor
Author
|
Hi, could we please get some attention on this one? :) |
AlekSi
approved these changes
Apr 27, 2021
boyan-soubachov
approved these changes
Apr 27, 2021
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
Thank you for fixing this :)
Contributor
Author
|
@boyan-soubachov Thanks for approving :)) |
Contributor
Author
|
@boyan-soubachov Can we please get a |
Collaborator
I will keep this in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure time.Time comparison produces a helpful diff. closes #989
Summary
Make sure time.Time comparison produces a helpful diff
again. This partially reverses the changes in #895 for
time.Time and allows it to be easily expanded for more
types in the future if needed.
Changes
Analyzes the type when diffing, and uses a different
Spew config for time.Time
Introduce a test for diffing time.Time
Motivation
See bug #989
Related issues
Closes #989