fix the output source file in test output#1026
Merged
boyan-soubachov merged 2 commits intostretchr:masterfrom Jan 15, 2021
Merged
fix the output source file in test output#1026boyan-soubachov merged 2 commits intostretchr:masterfrom
boyan-soubachov merged 2 commits intostretchr:masterfrom
Conversation
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
Thanks for this. Unfortunately this will slow down test execution speed but it has caught a reversion.
Could you possibly add a unit test to cover this problem and prevent the reversion from happening again in the future?
Author
|
Add some test. The implementation of the |
boyan-soubachov
approved these changes
Jan 15, 2021
Collaborator
boyan-soubachov
left a comment
There was a problem hiding this comment.
Looks great. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The file name in the failed summary shows files inside the
testifypackage, instead the real testing file. E.geThe
assertion_compare.gois a file insidetestifypackage. It should also showxxxx_test.go:352as theError Trace.Changes
Make functions inside
testifypackage as test helpers with:Motivation
With this PR, the filename and number would correctly show
xxxx_test.go:352Related issues