New tests for type_specific.go and fixed code#75
Merged
hanzei merged 2 commits intostretchr:masterfrom May 31, 2018
geseq:Type-Specific-tests
Merged
New tests for type_specific.go and fixed code#75hanzei merged 2 commits intostretchr:masterfrom geseq:Type-Specific-tests
hanzei merged 2 commits intostretchr:masterfrom
geseq:Type-Specific-tests
Conversation
Collaborator
|
@earncef Could you please run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was some code in type_specific.go:ObjxMapSlice() (migrated from the original type_specific_codegen.go) which seemed to be for the purpose of converting []interface{Map...} to []Map, but contained no tests and didn't work for []MSI or []interface{MSI...}
Fixed, and added tests.