chore: refactor package to use a dedicated submodule for the tests#154
chore: refactor package to use a dedicated submodule for the tests#154ccoVeille wants to merge 2 commits intostretchr:masterfrom ccoveille-forks:simplify-dependencies
Conversation
This allows to simplify the dependencies of the main module
|
This might be a naive approach, but it would make the package depency free. I opened because I was surprised to see this PR being opened in testify that uses |
I'm unsure since when it's broken
geseq
left a comment
There was a problem hiding this comment.
Nice one. Perhaps we should add a Makefile with test commands for easy testing locally.
|
I suspect that this new project structure breaks coverage reporting: tested code and tests must be in the same package. |
|
Yes, unfortunately |
|
Based on how much testify is extensively used in test, it won't be possible to replace testify by something else using stdlib. https://github.com/search?q=repo%3Astretchr%2Fobjx+%2Fassert%5C.%5BA-Z%5D%2F&type=code I tried to see if it was possible to remove testify dependency from objx, but it won't be possible. So the way is more in that direction |
Summary
This allows to simplify the dependencies of the main module
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
task testtask lint