Bump github.com/stretchr/testify from 1.7.1 to 1.8.0#121
Merged
Conversation
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.8.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.1...v1.8.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
@hanzei could you review/merge this one please? |
|
@geseq who appears to be the new maintainer - can you please investigate this one? Our security tooling is getting mad at us for the outdated version of testify :) |
Collaborator
|
Sorry, I don’t have the access to merge. |
stefanb
reviewed
Aug 21, 2022
| github.com/stretchr/testify/assert | ||
| github.com/stretchr/testify/require | ||
| # gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c | ||
| # gopkg.in/yaml.v3 v3.0.1 |
There was a problem hiding this comment.
This would fix two vulnerabilities:
- Denial of Service (DoS) CVE-2022-28948
v3: panic "attempted to parse unknown event (please report): none" go-yaml/yaml#666
https://snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV3-2841557 - NULL Pointer Dereference
v3: panic (nil pointer dereference) in parserc.go:789 go-yaml/yaml#665
https://snyk.io/vuln/SNYK-GOLANG-GOPKGINYAMLV3-2952714
I suggest to merge this and making a patch release ASAP.
Collaborator
|
@hanzei ping |
hanzei
approved these changes
Sep 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.7.1 to 1.8.0.
Commits
181cea6impr:CallerInfoshould print full paths to the terminal (#1201)cf1284fAllow mock expectations to be ordered (#1106)66eef0efix: assert.MapSubset (or just support maps in assert.Subset) (#1178)2fab6dfAdd WithinTimeRange method (#1188)b5ce165fixing panic in calls to assertion with nil m.mutex (#1212)c206b2eMock can be deadlocked by a panic (#1157)1b73601suite: correctly set stats on test panic (#1195)ba1076dAdd .Unset method to mock (#982)c31ea03Support comparing byte slice (#1202)48391baFix panic in AssertExpectations for mocks without expectations (#1207)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)