Add helpers for slice of Map#102
Merged
hanzei merged 2 commits intostretchr:masterfrom Feb 8, 2021
vyskocilm:master
Merged
Conversation
objx can't work with JSON documents starting with top-level array. This commit adds helpers FromJSONSlice and MustJSONSlice. Those returns `[]Map` enabling objx usage for this case as well.
geseq
requested changes
Feb 4, 2021
Collaborator
geseq
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM other than a small change.
geseq
approved these changes
Feb 4, 2021
Collaborator
|
cc @hanzei |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
objx can't work with JSON documents starting with top-level array. This
commit adds helpers FromJSONSlice and MustJSONSlice. Those returns
[]Mapenabling objx usage for this case as well.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
task testtask lint