Implement weeklyOSM notifications #6728
Merged
westnordost merged 19 commits intomasterfrom Feb 13, 2026
Merged
Conversation
# Conflicts: # app/src/androidMain/res/values-en/strings.xml # app/src/commonMain/composeResources/values-en/strings.xml
FloEdelmann
reviewed
Feb 11, 2026
...ain/kotlin/de/westnordost/streetcomplete/screens/settings/messages/MessageSelectionScreen.kt
Show resolved
Hide resolved
...ain/kotlin/de/westnordost/streetcomplete/screens/settings/messages/MessageSelectionScreen.kt
Show resolved
Hide resolved
...commonTest/kotlin/de/westnordost/streetcomplete/data/weeklyosm/WeeklyOsmRssFeedParserTest.kt
Outdated
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/weeklyosm/WeeklyOsmModule.kt
Show resolved
Hide resolved
app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/FeedsUpdater.kt
Outdated
Show resolved
Hide resolved
...src/commonMain/kotlin/de/westnordost/streetcomplete/screens/main/messages/WeeklyOsmDialog.kt
Outdated
Show resolved
Hide resolved
…pens after the first edits)
…eeklyosm/WeeklyOsmRssFeedParserTest.kt Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
…eedsUpdater.kt Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
FloEdelmann
reviewed
Feb 11, 2026
app/src/commonMain/kotlin/de/westnordost/streetcomplete/data/messages/MessagesSource.kt
Outdated
Show resolved
Hide resolved
…essages/MessagesSource.kt Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Member
Author
|
A comment on the PR itself: I am a bit taken aback how big of a boilerplate it is to implement a feature like that - parser, api client, updater, class that contains all the updaters, then the dance with the preferences and the listeners to the preferences... but I figured, even if the feature is small, I rather not skip all the architecture indirection just because the feature itself is simple and small. I think it is important to keep the code consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1796
also fixes #6493: Most in-app message types can now be disabled in the settings
also fixes #5977: The task that updates statistics, checks for new weeklyOSM, etc. is now executed each time the user tabs back into the app, but only once per day
Screen_recording_20260206_165413.mp4