Skip to content

Conversation

@sfc-gh-kbregula
Copy link
Contributor

@sfc-gh-kbregula sfc-gh-kbregula commented Apr 18, 2023

📚 Context

Continuation of work: #6495

To make it easier to test the "Release build" workflow, I made a few changes to make this workflow work on private forks. Especially, if the GitHub token is available, it is passed to HTTP requests and the correct permissions are set for the Github Action token.

In private forks, only the step "Upload to PyPI" is not running, because PyPi is a public package repository, so we don't want to put private artifacts in there.

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

🧠 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Insert screenshot of your updated UI/code here

Current:

Insert screenshot of existing UI/code here

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References

Does this depend on other work, documents, or tickets?

  • Issue: Closes #XXXX

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-kbregula sfc-gh-kbregula force-pushed the create-tag-for-release-with-security-issue branch from d2d64da to a89cb71 Compare April 28, 2023 23:07
@stale
Copy link

stale bot commented May 16, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 16, 2023
@stale stale bot closed this May 23, 2023
@vdonato vdonato deleted the create-tag-for-release-with-security-issue branch November 2, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants