Skip to content

Conversation

@sfc-gh-tteixeira
Copy link
Contributor

📚 Context

Updating our Cypress snapshots is very annoying -- so this workflow attempts to improve this process.
What this does:

  • Adds a new Github workflow called "Cypress update snapshots" (Named this way so it's near the "Cypress" workflow)
  • When you run this workflow, you first specify the e2e test you'd like to run:
    Screenshot 2023-01-23 at 16 42 34
  • ...and when the test is done running, you just downloads the screenshots it produced and add them to your PR.
    Screenshot 2023-01-23 at 16 44 28

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe: Tooling

🧠 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

n/a

Current:

n/a

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References

Does this depend on other work, documents, or tickets?


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@mayagbarnes mayagbarnes added the security-assessment-completed Security assessment has been completed for PR label Jan 25, 2023
@sfc-gh-tteixeira sfc-gh-tteixeira merged commit 25cd415 into streamlit:develop Jan 25, 2023
@sfc-gh-tteixeira sfc-gh-tteixeira deleted the snapshots branch January 25, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants