Add codeql code security and quality scan #5579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcgrady
approved these changes
Oct 21, 2022
Collaborator
kmcgrady
left a comment
There was a problem hiding this comment.
Left a comment question.
When should we dismiss or address the warnings?
| pull_request: | ||
| # The branches below must be a subset of the branches above | ||
| branches: ["develop"] | ||
| schedule: |
Collaborator
There was a problem hiding this comment.
This can run on any fork, right?
Collaborator
Author
There was a problem hiding this comment.
yes, i think so. Every PR going into develop
Collaborator
Author
There was a problem hiding this comment.
it also doesn't require any secrets or other things, so I don't expect any issues
Collaborator
Author
|
Regarding warnings: I just closed a few more warnings. If we figure out if we need to do something about the I think we can easily get the remaining warnings closed next week. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR adds Github CodeQL which adds static code security and quality scans. This will run automatically on all of our PRs.
See the scan results here: https://github.com/streamlit/streamlit/security/code-scanning?query=pr%3A5579+is%3Aopen+
What kind of change does this PR introduce?
Closes #3217
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.