Skip to content

UI tweaks #3: font family #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tvst merged 5 commits into from
Aug 26, 2021
Merged

UI tweaks #3: font family #3679

tvst merged 5 commits into from
Aug 26, 2021

Conversation

@tvst
Copy link
Contributor

@tvst tvst commented Aug 9, 2021

(Breaking up #3642 into multiple PRs)

  • Out with IBM Plex [X], in with Source [X] Pro
  • No longer package font with Streamlit, due to licensing
  • Include some great fallback fonts for when working offline.

NOTE: Screenshot tests coming after first round of reviews. Don't want to generate and re-generate as more reviews come in 😅

NOTE #2: Note the base branch for this PR. I'm basing it on the previous UI tweaks PR so the diff is easier to read. The idea is to merge in order.

@kinghuang
Copy link
Contributor

kinghuang commented Aug 9, 2021

Just repeating my ask from the closed PR for a font family that has a condensed font. IBM Plex * does, but Source * Pro does not. Relates to #3588.

@tvst
Copy link
Contributor Author

tvst commented Aug 9, 2021

Just repeating my ask from the closed PR for a font family that has a condensed font. IBM Plex * does, but Source * Pro does not. Relates to #3588.

Sadly, after trying a few dozen fonts, we couldn't find one that worked nearly as well as for Streamlit apps as Source * Pro.

The good news is that Source Sans Pro is actually super compact, so there should be less need for a condensed font.

Here is a comparison between normal Source Sans Pro and some condensed fonts:

Source Sans Pro
sourcesans

IBM Plex Sans Condensed
ibmplex

Fira Sans Condensed
firasans

Roboto Sans Condensed
roboto

From these, the only one that would give you any real winnings is Roboto. It's not a perfect visual match for Source Sans, but, frankly, it's fine 😆

@kinghuang
Copy link
Contributor

kinghuang commented Aug 9, 2021

Ok, fair enough. Thanks for showing the comparison!

kmcgrady
kmcgrady approved these changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@kmcgrady kmcgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of these comments are blocking, so I'll approve. Let me know if you have any questions.

@tvst tvst force-pushed the feature/ui-2-fontsizes branch from c916a53 to 569e708 Compare August 24, 2021 03:42
@tvst tvst force-pushed the feature/ui-3-fontfamily branch from fa5616f to cf326aa Compare August 25, 2021 05:32
@tvst tvst force-pushed the feature/ui-2-fontsizes branch from f2f2e1f to e563676 Compare August 26, 2021 06:09
Base automatically changed from feature/ui-2-fontsizes to feature/ui-updates August 26, 2021 06:26
@tvst tvst force-pushed the feature/ui-3-fontfamily branch from 7a7a9a2 to 732e2ac Compare August 26, 2021 06:36
@tvst tvst merged commit cb5c492 into feature/ui-updates Aug 26, 2021
@tvst tvst deleted the feature/ui-3-fontfamily branch August 26, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmcgrady kmcgrady kmcgrady approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvst @kinghuang @kmcgrady