[Fix] Consolidate border/hover colors #13536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates border and hover colors for st.radio, st.checkbox, and st.toggle widgets to improve consistency. The changes replace the 40% opacity fadedText40 color with borderColor (20% opacity) and update hover states from fadedText20 to darkenedBgMix15.
Key Changes:
- Updated border colors from
fadedText40toborderColorfor consistent 20% opacity across all widgets - Updated hover background colors from
fadedText20todarkenedBgMix15for better theming consistency - Updated E2E test snapshots to reflect the visual changes
Reviewed changes
Copilot reviewed 3 out of 222 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
frontend/lib/src/components/widgets/DataFrame/menus/ColumnVisibilityMenu.tsx |
Updated checkbox border color from fadedText40 to borderColor |
frontend/lib/src/components/widgets/Checkbox/Checkbox.tsx |
Updated both border and hover background colors to use consistent theme variables |
frontend/lib/src/components/shared/Radio/Radio.tsx |
Updated radio button border color from fadedText40 to borderColor |
e2e_playwright/__snapshots__/linux/st_toggle_test/*.png |
Updated visual regression test snapshots for toggle widget across themes and browsers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improve the consistency of our widget coloration in
st.radio,st.checkbox, &st.toggle- whose border and hover colors were different than other widgets.Current:
borderColor(viafadedText10)fadedText40Current:
Updated:
Testing Plan
NOTE: This does change tons of snapshots