[Fix] st.html handles list indentation
#13437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
✅ PR preview is ready!
|
225ebfd to
3610de9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a styling issue in the st.html component where nested lists (ul/ol/dl elements) were not displaying proper indentation due to global CSS resets. The fix restores appropriate padding to list elements within st.html components.
Key Changes
- Added CSS styling to restore
paddingLeftfor list elements using theme spacing (threeXL= 32px) - Added unit test to verify nested list DOM structure
- Added E2E test with snapshot comparison to verify visual indentation
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
frontend/lib/src/components/elements/Html/styled-components.ts |
Added padding restoration for ul/ol/dl elements to fix nested list indentation |
frontend/lib/src/components/elements/Html/Html.test.tsx |
Added unit test to verify nested lists render correctly in the DOM |
e2e_playwright/st_html.py |
Added test case with nested list HTML structure |
e2e_playwright/st_html_test.py |
Added E2E test to verify list indentation with snapshot testing and updated element counts |
e2e_playwright/__snapshots__/linux/st_html_test/st_html-nested_lists[webkit].png |
Added visual regression snapshot for WebKit browser |
e2e_playwright/__snapshots__/linux/st_html_test/st_html-nested_lists[firefox].png |
Added visual regression snapshot for Firefox browser |
e2e_playwright/__snapshots__/linux/st_html_test/st_html-nested_lists[chromium].png |
Added visual regression snapshot for Chromium browser |
sfc-gh-bnisco
approved these changes
Dec 22, 2025
|
This was amazingly fast - thank you @mayagbarnes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fix the styling in
st.htmlfor list indentationBefore:
After:
GitHub Issue Link (if applicable)
Closes #13426
Testing Plan