Remove Deprecated Code Function #10664
Merged
+0
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmasuch
approved these changes
Mar 7, 2025
Collaborator
lukasmasuch
left a comment
There was a problem hiding this comment.
LGTM 👍 good catch! thats not good that we have dead code :( wondering if there is a linting rule that could have prevented that. Maybe something to add to tech debt
Collaborator
Author
Hmmm, I think it would need to be a custom rule for Streamlit that checks the delta generator mixins for duplicate functions. We could use that library Bob was using for code generation to add some custom linting rules, I have used it for that in the past. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In this PR, we added a new
def codefunction incode.pywhich replaces the one inmarkdown.py.Since
CodeMixincomes first in the definition ofDeltaGeneratorbeforeMarkdownMixin, theCodeMixinversion of the function takes precedence due to python's MRO algorithm and we can safely remove this function.GitHub Issue Link (if applicable)
Testing Plan
Covered by existing tests.
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.