Skip to content

Undefined name github_doc_root in docs/conf.py #607

@cclauss

Description

@cclauss

Summary

Type here a clear and concise description of the bug. Aim for 2-3 sentences.

"url_resolver": lambda url: github_doc_root + url,
https://github.com/streamlit/streamlit/blob/develop/docs/conf.py#L206

github_doc_root is an undefined name in this context which has the possibility to raise NameError at runtime. Should this be defined as:
github_doc_root = "https://github.com/streamlit/streamlit/tree/master/docs"

Steps to reproduce

What are the steps we should take to reproduce the bug:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'

Expected behavior:

Explain what you expect to happen when you go through the steps above, assuming there were no bugs.

Actual behavior:

Explain the buggy behavior you experience when you go through the steps above.
If applicable, add screenshots to help explain your problem.

Is this a regression?

That is, did this use to work the way you expected in the past?
yes / no

Debug info

  • Streamlit version: (get it with $ streamlit version)
  • Python version: (get it with $ python --version)
  • Using Conda? PipEnv? PyEnv? Pex?
  • OS version:
  • Browser version:

Additional information

If needed, add any other context about the problem here.

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:bugSomething isn't working as expected

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions