Skip to content

Build broken on non-bash-based systems #555

@matthiasgoergens

Description

@matthiasgoergens

Summary

The Makefile uses bash-isms but doesn't explicitly ask for bash.

In Ubuntu, you get a POSIX compatible shell that doesn't know about eg [[

Steps to reproduce

  1. make setup

Expected behavior:

make setup works.

Actual behavior:

You get an error that says [[: not found.

Is this a regression?

Sorry, I haven't use streamlit in the past. The git history says that [[ was introduced into the Makefile at 62588bf.

Debug info

  • Streamlit version: develop
  • Python version: Python 3.7.4
  • OS version: Latest Ubuntu from docker hub
  • Browser version: Didn't install a browser.

Metadata

Metadata

Assignees

Labels

type:bugSomething isn't working as expected

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions