Skip to content

ci.github: add py314 Linux+Windows test runners #6589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 2 commits into from
Jun 27, 2025
Merged

ci.github: add py314 Linux+Windows test runners #6589

bastimeyer merged 2 commits into from
Jun 27, 2025

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jun 27, 2025

The Python 3.14 Linux runner was temporarily removed in #6561 because pytest hang for over an hour and then the runner got killed, as it expired. Let's see if it's working again.

Also let's add the Windows runner, with matching temp wheels of Streamlink's binary dependencies.

@bastimeyer
Copy link
Member Author

bastimeyer commented Jun 27, 2025

Both are failing... great...

https://github.com/streamlink/streamlink/actions/runs/15934327543/job/44950603303?pr=6589#step:7:55
https://github.com/streamlink/streamlink/actions/runs/15934327543/job/44950603286?pr=6589#step:7:54

tests/test_plugin.py ..............................FFFFFFEEEEEFFFFFFFFFF [ 12%]
FFFFFFFF                                                                 [ 12%]
tests/test_plugin_userinput.py EEEE                                      [ 12%]
tests/test_streamlink_api.py FFFFF                                       [ 12%]
tests/test_validate.py FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF [ 13%]

@bastimeyer
Copy link
Member Author

bastimeyer commented Jun 27, 2025

The Windows runner printed an error log after it got cancelled...

Looks like the issue is the monkeypatching of builtins.repr that breaks and which doesn't get reset, breaking all following tests:

streamlink/tests/test_plugin.py

Lines 383 to 391 in 0555139

def test_decorator_typeerror(self):
with patch("builtins.repr", Mock(side_effect=lambda obj: obj.__name__)):
with pytest.raises(TypeError) as cm:
# noinspection PyUnusedLocal
@pluginargument("foo")
class Foo:
pass
assert str(cm.value) == "Foo is not a Plugin"

@bastimeyer bastimeyer merged commit ba6959c into streamlink:master Jun 27, 2025
25 checks passed
@bastimeyer bastimeyer deleted the ci/github/cp314 branch June 27, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

continuous integration python: 3.14 tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bastimeyer