stream.dash: opt publishTime/availabilityStartTime #6324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove requirement from `publishTime` and `availabilityStartTime` in dynamic DASH manifests and simply default to UNIX Epoch.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove requirement from
publishTimeandavailabilityStartTimein dynamic DASH manifests and simply default to UNIX Epoch.Resolves #6322
According to ISO/IEC 23009-1:2022 section 5.3.1.2,
MPD@publishTimeis an optional attribute with a default value, and it "shall be present" in dynamic manifests, same as theMPD@availabilityStartTimeattribute. For static manifests, we've already set these attributes to optional in the parser, as they are not important in this case.For dynamic manifests however, defaulting to UNIX Epoch can be problematic, depending on whether segment timelines include at least one timestamp anchor or not. If they don't, as the
SegmentTimeline.S@tattribute is optional (section 5.3.9.6.2), then their anchor is the manifest's publishTime. Defaulting to 1970-01-01T00:00:00Z in dynamic manifests and using that as the anchor doesn't make sense, hence whyMPD@publishTimewas previously set as a required attribute.Parsers however should always be more lenient with data that's not 100% valid, so let's fix the attribute requirement.
The
MPD@availabilityStartTimechanges don't have any tests here, but that should be fine.