Skip to content

plugins.vk: fix API params and validation schema #6178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Sep 10, 2024
Merged

plugins.vk: fix API params and validation schema #6178

bastimeyer merged 1 commit into from
Sep 10, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Sep 10, 2024

Fixes #6177

This

  • simplifies the pluginmatchers
  • adds the missing list API request param (required by some videos)
  • adds the missing hls_ondemand/dash_ondemand items to the validation schema
  • handles inaccessible videos in the validation schema
  • updates the pluginmatcher and URL redirection tests
$ ./script/test-plugin-urls.py vk
:: https://vk.com/dota2?w=wall-126093223_1057924
::  144p, 240p, 360p, 480p, 720p, 1080p, worst, best
:: https://vk.com/search?c%5Bq%5D=dota&c%5Bsection%5D=auto&z=video295508334_171402661
::  144p, 240p, 360p, 480p, 720p, worst, best
:: https://vk.com/video-122792749_456242046?list=ln-YXS9u57K48LhkU6C3X
::  240p, 360p, 480p, 720p, 1080p, worst, best
:: https://vk.com/video-9944999_456239622
::  144p, 240p, 360p, 480p, 720p, worst, best
:: https://vk.com/video/@vesti?z=video-24136539_456241155%2Fpl_-24136539_-2
::  144p, 240p, 360p, worst, best
:: https://vk.com/video/lives?z=video-143491903_456240010
::  240p, 360p, 480p, 720p, 1080p, worst, best
:: https://vk.com/video132886594_167211693
::  144p, 240p, 360p, 480p, 720p, worst, best
:: https://vk.com/video?z=video-15755094_456245149%2Fpl_cat_lives
::  144p, 240p, 360p, 540p, worst, best
:: https://vk.com/video?z=video132886594_167211693%2Fpl_cat_8
::  144p, 240p, 360p, 480p, 720p, worst, best
:: https://vk.com/videos-24136539?z=video-24136539_456241155%2Fpl_-24136539_-2
::  144p, 240p, 360p, worst, best
:: https://vk.ru/video-9944999_456239622
::  144p, 240p, 360p, 480p, 720p, worst, best
:: https://www.vk.com/video-143491903_456240010
::  240p, 360p, 480p, 720p, 1080p, worst, best
:: https://www.vk.ru/video-143491903_456240010
::  240p, 360p, 480p, 720p, 1080p, worst, best

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Sep 10, 2024
@bastimeyer bastimeyer merged commit adbeccb into streamlink:master Sep 10, 2024
@bastimeyer bastimeyer deleted the plugins/vk/6177 branch September 10, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugins.vk: Could not parse API response

1 participant

@bastimeyer