Skip to content

plugins.vimeo: ignore unsupported DASH manifests #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Aug 12, 2024
Merged

plugins.vimeo: ignore unsupported DASH manifests #6128

bastimeyer merged 1 commit into from
Aug 12, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Aug 12, 2024

Resolves #6122

DASH manifests (sometimes?) are in the JSON format, which is unsupported.
Previously, it was possible to change the URL's path component and replace the manifest's file name extension,
but now, URLs are signed and can't be updated anymore, so simply discard those kinds of DASH manifest URLs.

$ streamlink https://vimeo.com/144358359
[cli][info] Found matching plugin vimeo for URL https://vimeo.com/144358359
Available streams: 204p (worst), 240p, 272p, 360p, 544p, 720p, 816p, 1080p (best)

$ ./script/test-plugin-urls.py vimeo
:: https://player.vimeo.com/video/176894130
!! Error while fetching streams
:: https://vimeo.com/783455878
::  240p, 360p, 540p, 720p, 1080p, worst, best
:: https://vimeo.com/channels/music/176894130
::  240p_hls, 1080p_hls, 720p_hls, 360p_hls, 540p_hls, 240p, 360p, 540p, 720p, 1080p, worst, best
:: https://vimeo.com/event/4154130
!! No streams found
:: https://vimeo.com/event/4154130/embed
!! No streams found
:: https://vimeo.com/ondemand/100footsurfingdays
::  360p, 540p, 720p, 1080p, worst, best
:: https://vimeo.com/ondemand/worldoftomorrow3/467204924
::  240p, 360p, 540p, 720p, 1080p, worst, best

One issue though, player.vimeo.com URLs can't be accessed, because cloudflare blocks python-requests/urllib3 with a 401 response. Surprisingly though, curl works:

$ curl 'https://player.vimeo.com/video/176894130' \
    -H 'Connection: keep-alive' \
    -H 'Cache-Control: no-cache' \
    -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36' \
    -vs

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Aug 12, 2024
@bastimeyer bastimeyer merged commit 949f083 into streamlink:master Aug 12, 2024
@bastimeyer bastimeyer deleted the plugins/vimeo/dash branch August 12, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugins.vimeo: Unsupported DASH path

1 participant

@bastimeyer