Skip to content

plugins.twitch: fix uppercase channel names #6071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Jul 7, 2024
Merged

plugins.twitch: fix uppercase channel names #6071

bastimeyer merged 1 commit into from
Jul 7, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jul 7, 2024

Resolves #6070

No idea if this justifies having another patch release just yet, considering that the Twitch plugin is priority number one... I'll think about it. Neither Twitch's website, nor my Twitch GUI use uppercase channel names in any way, so CLI users of Streamlink can always use lowercase channel names as a workaround in 6.8.2.

$ ./script/test-plugin-urls.py twitch -r CHANNELNAME HasanAbi -i video -i /v -i clip
:: https://player.twitch.tv/?parent=twitch.tv&channel=HasanAbi
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: https://www.twitch.tv/HasanAbi
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: https://www.twitch.tv/HasanAbi/
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: https://www.twitch.tv/HasanAbi/?
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: https://www.twitch.tv/HasanAbi?
::  audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jul 7, 2024
@bastimeyer bastimeyer merged commit 4c9814b into streamlink:master Jul 7, 2024
@bastimeyer bastimeyer deleted the plugins/twitch/fix-uppercase-channel-names branch July 7, 2024 21:18
@bastimeyer bastimeyer mentioned this pull request Jul 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugins.twitch: broken HLS stream URLs for channels with uppercase characters

1 participant

@bastimeyer