Skip to content

plugins.twitch: refactor matchers, fix clip URLs #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Jun 20, 2024
Merged

plugins.twitch: refactor matchers, fix clip URLs #6045

bastimeyer merged 1 commit into from
Jun 20, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Jun 20, 2024

master

$ streamlink https://www.twitch.tv/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
[cli][info] Found matching plugin twitch for URL https://www.twitch.tv/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
error: No playable streams found on this URL: https://www.twitch.tv/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4

PR

$ ./script/test-plugin-urls.py twitch -r CHANNELNAME pgl_dota2
:: Finding streams for URL: https://clips.twitch.tv/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
:: Found streams: 360p30, 480p30, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://player.twitch.tv/?parent=twitch.tv&channel=pgl_dota2
:: Found streams: audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://player.twitch.tv/?parent=twitch.tv&video=1963401646
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://player.twitch.tv/?parent=twitch.tv&video=1963401646&t=1h23m45s
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
:: Found streams: 360p30, 480p30, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/dota2ti/v/1963401646
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/dota2ti/video/1963401646
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/lirik/clip/GoodEndearingPassionfruitPMSTwin-QfRLYDPKlscgqt-4
:: Found streams: 360p30, 480p30, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/pgl_dota2
:: Found streams: audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/pgl_dota2/
:: Found streams: audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/pgl_dota2/?
:: Found streams: audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/pgl_dota2?
:: Found streams: audio_only, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/videos/1963401646
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best
:: Finding streams for URL: https://www.twitch.tv/videos/1963401646?t=1h23m45s
:: Found streams: audio, 160p, 360p, 480p, 720p, 720p60, 1080p60, worst, best

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Jun 20, 2024
@bastimeyer bastimeyer force-pushed the plugins/twitch/refactor-matchers branch from aa3beb6 to bb1ca5f Compare June 20, 2024 19:03
@bastimeyer bastimeyer merged commit 97d8e6d into streamlink:master Jun 20, 2024
@bastimeyer bastimeyer deleted the plugins/twitch/refactor-matchers branch June 20, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bastimeyer