build: only require exceptiongroup on py<3.11 #5987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `python_version<"3.11"` environment marker to `exceptiongroup`: It's a no-op package on Python 3.11 and above, so we don't have to require it on all Python versions. - Update compatibility imports - Update dependency docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python_version<"3.11"environment marker toexceptiongroup:It's a no-op package on Python 3.11 and above, so we don't have to require it on all Python versions.
exceptiongroupwas added in #5895.exceptiongroupalso includes a bugfix forcontextlib.suppresson<3.12.1, but that shouldn't be relevant to us:https://github.com/agronholm/exceptiongroup/blob/1.2.1/src/exceptiongroup/__init__.py#L43-L46
The reason for this dependency update is that some distros like Arch have already started phasing out their
python-exceptiongrouppackage because of their single Python 3.12 package where this compat lib is not needed:https://archlinux.org/todo/drop-python-exceptiongroup/
For some reason though, they simple dropped the dependency from their
streamlinkPKGBUILD and called it a day:https://gitlab.archlinux.org/archlinux/packaging/packages/streamlink/-/commit/956f62c4719bebb3311fbbee337ab780ad8baf4e