Skip to content

plugins.vimeo: fix offline event streams #5899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Mar 19, 2024
Merged

plugins.vimeo: fix offline event streams #5899

bastimeyer merged 1 commit into from
Mar 19, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Mar 19, 2024

Follow-up of #5892

This marks all url attributes in the validation schema as optional. Probably only necessary for HLS and DASH stream URLs, but I added it to progressive HTTP streams and subtitle URLs as well. Doesn't hurt...

master

$ streamlink https://vimeo.com/event/4154130/embed
[cli][info] Found matching plugin vimeo for URL https://vimeo.com/event/4154130/embed
error: Unable to validate result: ValidationError(dict):
  Unable to validate value of key 'request'
  Context(dict):
    Unable to validate value of key 'files'
    Context(dict):
      Unable to validate value of key 'hls'
      Context(dict):
        Unable to validate value of key 'cdns'
        Context(dict):
          Unable to validate value
          Context(dict):
            Key 'url' not found in {'origin': 'studio'}

PR

$ streamlink https://vimeo.com/event/4154130/embed
[cli][info] Found matching plugin vimeo for URL https://vimeo.com/event/4154130/embed
error: No playable streams found on this URL: https://vimeo.com/event/4154130/embed

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Mar 19, 2024
@bastimeyer bastimeyer merged commit 6e218ae into streamlink:master Mar 19, 2024
@bastimeyer bastimeyer deleted the plugins/vimeo/fix-offline-events branch March 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bastimeyer