Skip to content

session: fix missing plugin override log message #5844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Feb 20, 2024
Merged

session: fix missing plugin override log message #5844

bastimeyer merged 1 commit into from
Feb 20, 2024

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Feb 20, 2024

Fixes #5843

I didn't notice the missing log message because apparently I only checked this in a live environment from an editable install where all plugins get loaded at once like before, unlike in non-editable installs.

This bugfix justifies another patch release after merging. Will publish 6.6.2 later today...

$ pip install -q .
$ streamlink -V
streamlink 6.6.1+3.g21ef70bc
$ streamlink twitch.tv/smoke
[session][info] Plugin twitch is being overridden by /home/basti/.local/share/streamlink/plugins/twitch.py
[cli][info] Found matching plugin twitch for URL twitch.tv/smoke
Available streams: audio_only, 160p (worst), 360p, 480p, 720p60, 1080p60 (best)

@bastimeyer bastimeyer merged commit 73db061 into streamlink:master Feb 20, 2024
@bastimeyer bastimeyer deleted the session/plugins/fix-missing-override-log-msg branch February 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

API: session bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

session.plugins: No longer logs when plugin is overridden

1 participant

@bastimeyer