tests: fix session init #5799
Merged
tests: fix session init #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the session initialization rewrite using the plugins JSON data...
Despite there being the
sessionpytest fixture for initializing a Streamlink session object without loading any plugins, lots of tests are currently still manually initializing the session, which leads to all plugins being loaded every time. This slows down the tests significantly. On my local system, these changes improve the run time from ~15s to ~10s.The upcoming plugins JSON data implementation will make lots of changes to the Streamlink class, so patching the
load_builtin_plugins()method won't be necessary anymore in the tests afterwards.