Skip to content

plugins.twitch: only log errors if channel is live #5709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Dec 6, 2023
Merged

plugins.twitch: only log errors if channel is live #5709

bastimeyer merged 1 commit into from
Dec 6, 2023

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Dec 6, 2023

Follow-up of #5708
Improves #5591

No more unnecessary error log messages for offline channels (twirp error not_found: transcode does not exist).
Error log messages for geo-blocked content or other kinds of errors are kept.

Online

$ streamlink twitch.tv/shroud
[cli][info] Found matching plugin twitch for URL twitch.tv/shroud
Available streams: audio_only, 160p (worst), 360p, 480p, 720p, 720p60, 1080p60 (best)

Offline

$ streamlink twitch.tv/lirik
[cli][info] Found matching plugin twitch for URL twitch.tv/lirik
error: No playable streams found on this URL: twitch.tv/lirik

Offline (corrupt data on Twitch's end)

$ streamlink twitch.tv/paymoneywubby
[cli][info] Found matching plugin twitch for URL twitch.tv/paymoneywubby
error: No playable streams found on this URL: twitch.tv/paymoneywubby

Geo-blocked content currently not available, but tests have the necessary data. Would look like this:

$ streamlink twitch.tv/primevideo
[cli][info] Found matching plugin twitch for URL twitch.tv/primevideo
[plugins.twitch][error] Content Restricted In Region
error: No playable streams found on this URL: twitch.tv/primevideo

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Dec 6, 2023
@bastimeyer bastimeyer merged commit a169d5b into streamlink:master Dec 6, 2023
@bastimeyer bastimeyer deleted the plugins/twitch/log-error-if-live branch December 6, 2023 05:35
@ManeTV
Copy link

ManeTV commented Mar 22, 2024

Hello, sorry I'm really clueless about all this so wanted to say it honestly. I want to get rid of the "(twirp error not_found: transcode does not exist" message spam in my recorder when a channel I was recording goes offline. I checked the files provided: src/streamlink/plugins/twitch.py and tests/plugins/test_twitch.py and looked in my pc to see if I have those, too. Noticed I only have the twitch.py file in this directory: Streamlink\pkgs\streamlink\plugins and I don't have the othe file anywhere in my Streamlink folder, I don't even have a tests/plugins directory which I guess is normal. I'm stuck on what to do from here... I'll be trying to do more trial and error while waiting for a response if anyone can help. Thank you so much in advance.

@bastimeyer
Copy link
Member Author

bastimeyer commented Mar 22, 2024

I'm really clueless about all this

Install the latest version
https://streamlink.github.io/install.html

@streamlink streamlink locked as resolved and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bastimeyer @ManeTV