Skip to content

plugins.nos: rewrite and fix plugin #5565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Sep 21, 2023
Merged

plugins.nos: rewrite and fix plugin #5565

bastimeyer merged 1 commit into from
Sep 21, 2023

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Sep 21, 2023

Fixes #5555

@ltguillaume could you please check and verify?
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback

URLs of the type https://nos.nl/artikel/... are explicitly not supported, because adding a validation schema for getting the HLS URLs is a bit ridiculous (different JSON payload, nested objects, multiple kinds of video schemas).

$ ./script/test-plugin-urls.py nos
:: Finding streams for URL: https://nos.nl/collectie/13781/livestream/2385081-ek-voetbal-engeland-schotland
:::: Content is inaccessible or may have expired
!! No streams found
:: Finding streams for URL: https://nos.nl/collectie/13951/video/2491092-dit-was-prinsjesdag
:: Found streams: 360p, 480p, 720p, 1080p, worst, best
:: Finding streams for URL: https://nos.nl/live
:: Found streams: 360p, 480p, 720p, 1080p, worst, best
:: Finding streams for URL: https://nos.nl/video/2490788-meteoor-gespot-boven-noord-nederland
:: Found streams: 360p, 480p, 720p, 1080p, worst, best

@bastimeyer bastimeyer added the plugin issue A Plugin does not work correctly label Sep 21, 2023
@ltguillaume
Copy link

ltguillaume commented Sep 21, 2023

Can confirm working:

So all is well now, thank you!

At first, I thought that perhaps https://nos.nl/collectie/... would have iterated the videos available and play them in order, but that was just an assumption.

@bastimeyer bastimeyer merged commit 10597f8 into streamlink:master Sep 21, 2023
@bastimeyer bastimeyer deleted the plugins/nos/rewrite branch September 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin issue A Plugin does not work correctly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugins.nos: No playable streams found on this URL

2 participants

@bastimeyer @ltguillaume