plugins.nicolive: add metadata #5529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for picking this up! Appreciate it! I spent about an hour testing this with various livestreamers,vods,logged in,logged out,premium user etc and from what I can see it works perfectly! I tried grabbing a full log but unfortunately encountered some errors. See #5531 I've omitted some id's/tokens because they might be sensitive. |
57c5e44 to
616096e
Compare
Member
Author
|
Thanks for testing. The encoding bug with the log file on Windows should be fixed on master now. I force-pushed another change an hour ago here which fixes the detection of offline streams which I broke when I removed the unnecessary suppression of schema validation errors. Going to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5515
I am not sure though if this could break some streams, because metadata is not treated optionally, so if it's missing, then the validation schema could fail.
@SecondaryH could you please check some more streams (preferrably with a login - which I don't have) and verify these changes? Thanks!
https://github.com/streamlink/streamlink/blob/master/CONTRIBUTING.md#pull-request-feedback
Some streams I've checked:
1. From the tests file:
streamlink --json https://live.nicovideo.jp/watch/co2619719 best | jq .metadata{ "id": "lv342666086", "author": "novoll(千葉県民)", "category": null, "title": "【SFC】魔法騎士レイアース 初見プレイ【13枠目】" }2. Picked randomly from their site
streamlink --json https://live.nicovideo.jp/watch/lv342666014 best | jq .metadata{ "id": "lv342666014", "author": "ノンケのねねし", "category": null, "title": "【スト６】9月16日、17日に仙台で大規模大会があります（ラウンジ）【ノンケ配信記】" }