plugins.openrectv: fix 401 error #5291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastimeyer
reviewed
Apr 16, 2023
src/streamlink/plugins/openrectv.py
Outdated
| log.error("There is no video file.") | ||
|
|
||
| if m3u8_file is not None: | ||
| self.session.http.headers.update({"Referer": "https://www.openrec.tv/"}) |
Member
There was a problem hiding this comment.
Probably better to use self.url instead, so the plugin doesn't rely on a hardcoded string literal.
And as an alternative to setting the header on the entire http session, headers={...} could be set as a keyword on the parse_variant_playlist() call.
Contributor
Author
|
Thank you for the review and suggestions. |
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENREC.tv recently made a small change.
When fetching m3u8, it now returns 401 if "https://www.openrec.tv" is not specified in the referer.
So I avoid that error by adding a referer.