chore: aware datetimes #5210
Merged
chore: aware datetimes #5210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add "DTZ" ruff rule - Add utility functions to `streamlink.utils.times` which use "aware" datetimes with explicit timezone information, and use `isodate`'s local timezone implementation - Replace all "naive" datetimes without timezone information - Replace all custom ISO8601 parsers with `isodate`'s implementation - Add tests for new utility functions
cb7ffba to
effa92c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamlink.utils.timeswhich use "aware" datetimes with explicit timezone information, and useisodate's local timezone implementationisodate's implementationhttps://docs.python.org/3/library/datetime.html#aware-and-naive-objects
https://beta.ruff.rs/docs/rules/#flake8-datetimez-dtz