build: update build script #5077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `build` to build sdist and wheels instead of calling setuptools directly, which is deprecated.
Member
|
Looks good, nice improvement! |
Member
Author
|
There's also gpg ... --passphrase="${RELEASE_KEY_PASSPHRASE}" ...which should be changed to gpg ... --passphrase-fd 0 ... <<< "${RELEASE_KEY_PASSPHRASE}"but I didn't want to touch this. The PyPI user+pass are also passed as parameters to Btw, I don't have the password for the encrypted signing key (462165d) and it's also not on the protonmail account. I believe only @beardypig has it. If nobody else has it, then I'll send him an email (I don't think he'll see this message) |
Member
|
I double checked and I don't have the password for the signing key. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
buildto build sdist and wheels instead of calling setuptools directly, which is deprecated.See
https://github.com/pypa/build
I've checked the sdist tarball and the built wheels, and everything looked okay to me. The win32 and win-amd64 wheels also have the correct GUI entry scripts (streamlinkw).