cli: refactor console.exit() calls #5044
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6093c6 to
02e8804
Compare
Member
Author
|
Rebased to master in order to fix missing CI status checks with the new branch protection rules. In regards to the changes, I will still have to take a closer look. So far, this is just a simple replacement of the |
- Replace various console.exit() calls with a CLIExit() exception - Fix tests
02e8804 to
22ae2d4
Compare
Member
Author
|
Rebased and fixed merge conflict. Still need to take a closer look at the changes. |
Member
Author
|
Will open a new PR at some point in the future... This one is old, requires a rebase and lots of more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small cleanup in regards to
console.exit()in the main CLI module. This replaces these directconsole.exit()calls with aCLIExitexception that gets raised instead and then gets caught down in themain()function. This fixes static code analysis and makes writing tests a bit easier. And it allows for additional cleanup code in case of an error, but nothing of that kind is being implemented here yet. Also no tests for the handling of theCLIExitexceptions themselves, but that's not too important.Also decided to rewrite the stream-url and JSON tests, because they were pretty bad. Still no improvements of the code being tested, though, and also no error codes, but this can all be done later.
Opening this as a draft for now, because I didn't have the time to check everything in detail yet...