stream: add session typing information #4814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add typing information to `Stream` - Explicitly set the stream, reader, worker and writer types - Fix minor typing issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamFollow-up of #4802, which was a requirement for being able to add session typing information to the stream classes.
Some typing definitions are redundant, but since some are not, I chose setting all of them explicitly, to make it more consistent.
The stream classes which I didn't touch are either untyped or don't require any changes. And the other changes are minor typing fixes, removals of redundant stuff (duplicate
self.stream = self.reader.stream) and updates of legacy py2 code (super()calls).