-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
plugins.dogus: add dmax + tlc, fix startv #4409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
this is not Doğuş Media Group, it is Discovery, Inc. If made correctly, this should be a new plugin and not be added here. edit: |
|
@back-to |
|
@back-to Discovery group's partner in Turkey is Dogus group. Ntv Spor channel changed its name to D Max. https://www.google.com/amp/s/t24.com.tr/amp/haber/dogustan-discovery-ile-stratejik-ortaklik,304646 I'm from Turkey. I made such a request because Tlc and D Max had organic ties to the Doğuş group. You can delete my request to pull. I just wanted to help. Sorry. I should've kept it to myself. Good bye. |
|
Maybe the existing tlctr plugin should be removed then? @omergorur, you should also update |
The sites themselves don't say anything about that: Wikipedia however has a link to So if we're going to merge this, then either
@back-to plugin removal or not? |
|
plugins.turkuvaz: add vavtv I dont create smoothly another pull. So sorry |
|
@omergorur, yes, what you did before (creating another PR for a different plugin modification) is fine and generally preferred. |
bastimeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't do multiple plugin changes in a single PR.
This PR will also require a review from @back-to until we've decided whether we want to drop the already existing tlctr plugin.
|
@omergorur, it may help you to read https://streamlink.github.io/developing.html and https://streamlink.github.io/developing.html#validating-changes in particular so that you can lint the changes you make before pushing them to GitHub and check the tests as well. |
|
startv seems to work without any changes there are static URLs for TLC and DMAX, no plugin needed currently DMAX TLC the TLC plugin can be removed. |
add dmax and tlc. fix startv.com.tr