Skip to content

Conversation

@omergorur
Copy link
Contributor

add dmax and tlc. fix startv.com.tr

@bastimeyer bastimeyer added the plugin enhancement A new feature for a working Plugin label Mar 27, 2022
@bastimeyer bastimeyer changed the title add dmax and tlc. fix startv.com.tr plugins.dogus: add dmax + tlc, fix startv Mar 27, 2022
@omergorur omergorur requested a review from bastimeyer March 27, 2022 04:49
@back-to
Copy link
Collaborator

back-to commented Mar 27, 2022

this is not Doğuş Media Group, it is Discovery, Inc.
https://en.wikipedia.org/wiki/Television_in_Turkey

If made correctly, this should be a new plugin and not be added here.


edit:

also https://github.com/streamlink/streamlink/blob/90230e4c9dec12097bab93917dd3e396356d923a/src/streamlink/plugins/tlctr.py

@bastimeyer
Copy link
Member

@back-to
The HLS streams are on this hostname though dogus.daioncdn.net

@omergorur
Copy link
Contributor Author

@back-to Discovery group's partner in Turkey is Dogus group. Ntv Spor channel changed its name to D Max.

https://www.google.com/amp/s/t24.com.tr/amp/haber/dogustan-discovery-ile-stratejik-ortaklik,304646

I'm from Turkey. I made such a request because Tlc and D Max had organic ties to the Doğuş group.

You can delete my request to pull. I just wanted to help. Sorry. I should've kept it to myself. Good bye.

@omergorur omergorur closed this Mar 27, 2022
@omergorur omergorur reopened this Mar 27, 2022
@mkbloke
Copy link
Member

mkbloke commented Mar 27, 2022

Maybe the existing tlctr plugin should be removed then?

@omergorur, you should also update should_match[] in test_dogus.py with the two new live channel URLs you have added to the plugin.

@bastimeyer
Copy link
Member

Tlc and D Max had organic ties to the Doğuş group.

The sites themselves don't say anything about that:
https://www.dmax.com.tr/bilgi-toplumu-hizmetleri
https://www.tlctv.com.tr/bilgi-toplumu-hizmetleri

Wikipedia however has a link to
https://web.archive.org/web/20160207123904/http://www.digitaltveurope.net/440191/discovery-launches-tlc-in-turkey-via-dogus-partnership/

So if we're going to merge this, then either

  • tlctv.com.tr would need to get removed here, as there's already the dedicated tlctr plugin. That would however make adding dmax.com.tr here questionable, as it uses the same logic for extracting the stream URLs
  • or the dedicated tlctr plugin would have to get removed, which would require a rebase/cleanup of this PR, as we're not going to merge multiple commits on top of the required separate plugin removal commit. I can clean this up though, as long as I have write permissions on the repo branch of this PR.

@back-to plugin removal or not?

@omergorur omergorur changed the title plugins.dogus: add dmax + tlc, fix startv plugins.dogus: add dmax + tlc, fix startv and plugins.turkuvaz: add vavtv Apr 2, 2022
@omergorur omergorur requested a review from bastimeyer April 2, 2022 02:01
@omergorur
Copy link
Contributor Author

omergorur commented Apr 2, 2022

plugins.turkuvaz: add vavtv

I dont create smoothly another pull. So sorry

@mkbloke
Copy link
Member

mkbloke commented Apr 2, 2022

@omergorur, yes, what you did before (creating another PR for a different plugin modification) is fine and generally preferred.

@bastimeyer bastimeyer changed the title plugins.dogus: add dmax + tlc, fix startv and plugins.turkuvaz: add vavtv plugins.dogus: add dmax + tlc + vavtv, fix startv Apr 2, 2022
@bastimeyer bastimeyer changed the title plugins.dogus: add dmax + tlc + vavtv, fix startv plugins.dogus: add dmax + tlc, fix startv Apr 2, 2022
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do multiple plugin changes in a single PR.

This PR will also require a review from @back-to until we've decided whether we want to drop the already existing tlctr plugin.

@bastimeyer bastimeyer requested a review from back-to April 2, 2022 02:38
@mkbloke
Copy link
Member

mkbloke commented Apr 2, 2022

@omergorur, it may help you to read https://streamlink.github.io/developing.html and https://streamlink.github.io/developing.html#validating-changes in particular so that you can lint the changes you make before pushing them to GitHub and check the tests as well.

@back-to
Copy link
Collaborator

back-to commented Apr 3, 2022

startv seems to work without any changes

$ streamlink -l info https://www.startv.com.tr/canli-yayin
[cli][info] Found matching plugin dogus for URL https://www.startv.com.tr/canli-yayin
[cli][info] Available streams: 180p_alt (worst), 180p, 288p_alt, 288p, 477p_alt, 477p, 720p_alt, 720p (best)
[cli][info] Opening stream: 720p (hls)

there are static URLs for TLC and DMAX, no plugin needed currently

DMAX
https://dogus-live.daioncdn.net/dmax/dmax.m3u8

TLC
https://dogus-live.daioncdn.net/tlc/tlc.m3u8

the TLC plugin can be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin enhancement A new feature for a working Plugin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants