setup: drop pycrypto support #4174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove the `STREAMLINK_USE_PYCRYPTO` env var switch from setup.py - sort dependencies list - update dependencies section in install docs - sort dependencies table - rephrase notes column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STREAMLINK_USE_PYCRYPTOenv var switch from setup.pyref #4170, #713
pycrypto has had its last update in 2013
https://pypi.org/project/pycrypto/#history
As I've shown in #4170, there are no streamlink packages (anymore) which depend on pycrypto. If I missed one, then they will have to upgrade.
I included the updates for the docs in this commit because I don't want to post two PRs. I also removed the versions of non-build-dependencies from the docs because they were never up2date and it doesn't make sense having two lists for this. The only dependency list that matters is the one in setup.py (or setup.cfg if we move to a declarative list). Please take a look at the rendered docs preview to see if everything's okay.