-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
cli: add title to json #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: add title to json #3941
Conversation
bastimeyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
You are introducing a breaking change of Streamlink's CLI with that. I am not sure if this is worth adding right now. Maybe later when we decide to bump the major release version.
Also, before this can get merged, the tests need to be fixed first, which includes the mocked test setup which is currently not ideal for the title metadata.
|
After thinking about it again (I only had the diff in mind in my previous comment, sorry), do we want the interpolated The |
both
i have a script that use streamlink as mpv backend instead of youtube-dl for some specific sites like twitch... $ |
|
What I am saying is that the JSON data should not include the custom {
"type": "hls",
"url": "https://foo",
"master": "https://bar",
"headers": {},
"metadata": {
"author": ...,
"category": ...,
"title": ...,
}
} |
|
i am not sure if this is worth adding right now ; also this way respect the formate in streamlink config file if i called |
used as mpv backend :
