Skip to content

chore: remove deprecated CLI arguments #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gravyboat merged 1 commit into from
Oct 22, 2020
Merged

chore: remove deprecated CLI arguments #3277

gravyboat merged 1 commit into from
Oct 22, 2020

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Oct 22, 2020

This removes the following deprecated/suppressed CLI arguments:

  • --http-cookies
    Multiple --http-cookie arguments need to be used
  • --http-headers
    Multiple --http-header arguments need to be used
  • --http-query-params
    Multiple --http-query-param arguments need to be used
  • --no-version-check
    Version checking is opt-in via --version-check or --auto-version-check
  • --twitch-oauth-authenticate
    Auth on Twitch is not possible with OAuth tokens generated by 3rd-party client-IDs like Streamlink's

And the following deprecated/suppressed plugin arguments:

  • --btv-username / --btv-password
  • --crunchyroll-locale
    Generic --locale argument needs to be used
  • --pixiv-username / --pixiv-password
  • --twitch-oauth-token / --twitch-cookie
    As a workaround, --http-header="Authorization=OAuth oauth-token-from-twitch-website" can be used
  • --ustvnow-station-code
  • --youtube-api-key

@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 22, 2020

There's also the issue with the various mux-subtitles plugin arguments and merging them all into one global argument. Ideally, this should be done in the 2.0.0 release due to the major version bump, but it's optional.

@mkbloke
Copy link
Member

mkbloke commented Oct 22, 2020

There's also the issue with the various mux-subtitles plugin arguments and merging them all into one global argument. Ideally, this should be done in the 2.0.0 release due to the major version bump, but it's optional.

It really seems like the preferable way to go while breaking changes are already being made, otherwise I guess Streamlink will be stuck with the current implementation until release 3.0.0.

@bastimeyer bastimeyer mentioned this pull request Oct 22, 2020
Closed
25 tasks
@gravyboat
Copy link
Member

gravyboat commented Oct 22, 2020

Looks good to me!

@gravyboat gravyboat merged commit d8c8a02 into streamlink:master Oct 22, 2020
@beardypig
Copy link
Member

beardypig commented Oct 22, 2020

@bastimeyer how would you merge those mux subtitles options?

@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 22, 2020 •
edited
Loading

By adding one global --mux-subtitles boolean parameter and removing the individual plugin parameters from

  • funimationnow
  • pluzz
  • rtve
  • svtplay
  • vimeo

and making the plugins read the global parameter value instead. Looks like a simple change to be honest.

@beardypig
Copy link
Member

beardypig commented Oct 22, 2020

Yeah, my only concern is that users might assume a plugin supports mux-subtitles where it does not.

@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 22, 2020

An info log message could be added to each of the supported plugins. Maybe even as a decorator, to unify the log message.

@beardypig
Copy link
Member

beardypig commented Oct 22, 2020

@bastimeyer I created #3282 to continue the discussion.

@bastimeyer bastimeyer deleted the deprecations/cli-arguments branch January 19, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bastimeyer @mkbloke @gravyboat @beardypig