chore: remove py2 compat stuff #3270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I will rebase this once #3269 got merged, so that the checks will all pass. |
This was referenced Oct 19, 2020
2c949e7 to
efb1e50
Compare
back-to
approved these changes
Oct 19, 2020
efb1e50 to
f538d68
Compare
Member
Author
|
Forgot to remove one remaining thing from the compat module. Should be good now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've split up everything into logical chunks, so when reviewing the changes, please check the individual commits. This looks like much, but it's all rather simple.
In addition to removing the compat imports, I've also corrected the import order in some modules, but not all of them. Only where it made the most sense.