Skip to content

chore: drop support for Python 2 #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bastimeyer merged 1 commit into from
Oct 19, 2020
Merged

chore: drop support for Python 2 #3232

bastimeyer merged 1 commit into from
Oct 19, 2020

Conversation

@bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Oct 7, 2020 •
edited
Loading

  • Bump Python version requirement to 3.5
  • Remove unneeded compatibility dependencies
  • Remove py2 warning from streamlink.session
  • Update pypi package classifiers
  • Update docs
  • Remove universal bdist_wheel
  • Remove py2 from CI test runners

This is WIP and needs to be properly tested in a test-release first.

Additional resources:

Resolves #2896
Closes #2920

@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 7, 2020 

$ python --version
Python 2.7.18
$ pip install -e .
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Obtaining file:///home/basti/repos/streamlink
ERROR: Package 'streamlink' requires a different Python: 2.7.18 not in '>=3.5, <4'

@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 7, 2020

Next steps (in separate PRs) after this has been merged:

  1. Remove compat stuff
    This involves all imports from the compat modules and also custom if is_py2 checks, etc. This can't be automated.
  2. Remove py2 specifics and translate code into "modern" py3 code
    Most of it can be automated, but not everything. This is all optional, but should be done eventually. With the removal of py35, even more new syntax features become available, but that should be a separate step.
    The automation tool used in one of the other PRs unfortunately hardcodes the features it translates into py3, so before running it, the unwanted stuff needs to be disabled first.

Oh, and I'd recommend having a 1.6.1 or 1.7.0 release before bumping to 2.0.0

@bastimeyer bastimeyer force-pushed the py2-removal branch 2 times, most recently from 51b3047 to 4cd86ba Compare October 7, 2020 10:23
@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 7, 2020

I have the compatibility removal branch in a somewhat ready state here:
bastimeyer/streamlink@py2-removal...bastimeyer:py2-compat-removal

back-to
back-to reviewed Oct 7, 2020
View reviewed changes
@bastimeyer bastimeyer mentioned this pull request Oct 8, 2020
Closed
25 tasks
@bastimeyer bastimeyer force-pushed the py2-removal branch 2 times, most recently from e150501 to 8f6da5d Compare October 10, 2020 04:39
gravyboat
gravyboat approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up from me, looks good!

@bastimeyer
chore: drop support for Python 2
940173e 
- Bump Python version requirement to 3.5
- Remove unneeded compatibility dependencies
- Remove py2 warning from streamlink.session
- Update pypi package classifiers
- Update docs
- Remove universal bdist_wheel
- Update CI test runners and codecov config
@bastimeyer
Copy link
Member Author

bastimeyer commented Oct 19, 2020 •
edited
Loading

Rebased and squashed both commits and updated the commit message accordingly.
Going to merge now, as everyone has approved. 🎉

@bastimeyer bastimeyer merged commit 8034b16 into streamlink:master Oct 19, 2020
@bastimeyer bastimeyer deleted the py2-removal branch December 12, 2020 01:14
@bastimeyer bastimeyer mentioned this pull request Dec 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gravyboat gravyboat gravyboat approved these changes

@beardypig beardypig beardypig approved these changes

@back-to back-to back-to approved these changes

Assignees

No one assigned

Labels

python-2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Python 2.7 support

4 participants

@bastimeyer @gravyboat @beardypig @back-to